From 016c68d76ff0c5b03b2e6077ea3971091ff077e2 Mon Sep 17 00:00:00 2001 From: thiuda Date: Thu, 24 Mar 2022 21:21:07 +0100 Subject: [PATCH 1/4] fix lint errors --- tasks/main.yml | 30 +++++++++++++++--------------- 1 file changed, 15 insertions(+), 15 deletions(-) diff --git a/tasks/main.yml b/tasks/main.yml index 5cbd3bc..49357ba 100644 --- a/tasks/main.yml +++ b/tasks/main.yml @@ -1,6 +1,6 @@ - name: Ensure packages are installed - become: yes - apt: + become: true + ansible.builtin.apt: name: - python3-pip - apt-transport-https @@ -11,42 +11,42 @@ state: present - name: Trust dockers GPG key - become: yes - apt_key: + become: true + ansible.builtin.apt_key: url: https://download.docker.com/linux/debian/gpg state: present - name: Ensure docker repository is available - become: yes - apt_repository: + become: true + ansible.builtin.apt_repository: repo: deb https://download.docker.com/linux/debian buster stable state: present # notify: Update apt cache -#- name: Flush handlers -# meta: flush_handlers +# - name: Flush handlers +# meta: flush_handlers - name: Ensure packages are installed - become: yes - apt: + become: true + ansible.builtin.apt: name: - docker-ce - docker-ce-cli - containerd.io - docker-compose - update_cache: yes + update_cache: true state: present - name: Install docker python module - become: yes - pip: + become: true + ansible.builtin.pip: executable: pip3 name: - docker - name: Change docker root - become: yes - template: + become: true + ansible.builtin.template: src: templates/daemon.json.j2 dest: /etc/docker/daemon.json mode: 0644 From 1fd31e859e41ca6b4386d4b35e92c8eb5707b1d5 Mon Sep 17 00:00:00 2001 From: thiuda Date: Fri, 22 Apr 2022 15:16:42 +0200 Subject: [PATCH 2/4] ignore fqcn-builtins lint errors for builtin actions --- .ansible-lint | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 .ansible-lint diff --git a/.ansible-lint b/.ansible-lint new file mode 100644 index 0000000..2aea330 --- /dev/null +++ b/.ansible-lint @@ -0,0 +1,3 @@ +--- +skip_list: + - fqcn-builtins From f2d367493bbe737b721f4e5a31c10a48d604fdaa Mon Sep 17 00:00:00 2001 From: thiuda Date: Fri, 22 Apr 2022 15:16:42 +0200 Subject: [PATCH 3/4] ignore fqcn-builtins lint errors for builtin actions --- .ansible-lint | 3 +++ tasks/main.yml | 12 ++++++------ 2 files changed, 9 insertions(+), 6 deletions(-) create mode 100644 .ansible-lint diff --git a/.ansible-lint b/.ansible-lint new file mode 100644 index 0000000..2aea330 --- /dev/null +++ b/.ansible-lint @@ -0,0 +1,3 @@ +--- +skip_list: + - fqcn-builtins diff --git a/tasks/main.yml b/tasks/main.yml index 49357ba..3b5a5a6 100644 --- a/tasks/main.yml +++ b/tasks/main.yml @@ -1,6 +1,6 @@ - name: Ensure packages are installed become: true - ansible.builtin.apt: + apt: name: - python3-pip - apt-transport-https @@ -12,13 +12,13 @@ - name: Trust dockers GPG key become: true - ansible.builtin.apt_key: + apt_key: url: https://download.docker.com/linux/debian/gpg state: present - name: Ensure docker repository is available become: true - ansible.builtin.apt_repository: + apt_repository: repo: deb https://download.docker.com/linux/debian buster stable state: present # notify: Update apt cache @@ -28,7 +28,7 @@ - name: Ensure packages are installed become: true - ansible.builtin.apt: + apt: name: - docker-ce - docker-ce-cli @@ -39,14 +39,14 @@ - name: Install docker python module become: true - ansible.builtin.pip: + pip: executable: pip3 name: - docker - name: Change docker root become: true - ansible.builtin.template: + template: src: templates/daemon.json.j2 dest: /etc/docker/daemon.json mode: 0644 From 64fa63824409721862f5e664024283f4fe7e6164 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Micha=20Gl=C3=A4=C3=9F-St=C3=B6cker?= Date: Wed, 20 Jul 2022 09:15:48 +0200 Subject: [PATCH 4/4] make the role usable on "all" debian versions --- tasks/main.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tasks/main.yml b/tasks/main.yml index 3b5a5a6..fdf420c 100644 --- a/tasks/main.yml +++ b/tasks/main.yml @@ -19,7 +19,7 @@ - name: Ensure docker repository is available become: true apt_repository: - repo: deb https://download.docker.com/linux/debian buster stable + repo: deb https://download.docker.com/linux/debian {{ ansible_distribution_release }} stable state: present # notify: Update apt cache