docker-multiarch/openwrt-firmware-selector
1
0
Fork 0
mirror of https://git.netzspielplatz.de/docker-multiarch/openwrt-firmware-selector.git synced 2025-11-08 22:29:28 +00:00
Code Issues Projects Releases Wiki Activity

add more tests. Push code coverage to codecov

Browse source
This commit is contained in:
Sudhanshu Gautam 2021-01-13 18:41:12 +05:30
parent d6283eca43
commit 7d24fcfd4b
15 changed files with 382 additions and 51 deletions
Download patch file Download diff file Expand all files Collapse all files

23
src/containers/home/components/ProfileDetails.tsx
View file

@ -20,16 +20,13 @@ import { useTranslation } from 'react-i18next';
import { ProfilesEntity } from '../../../types/overview';
import { Profile, TitlesEntity } from '../../../types/profile';
import config from '../../../config';
import { getTitle } from '../utils/title';
type Props = {
selectedVersion: string;
selectedProfile: ProfilesEntity;
};
const getTitle = (title: TitlesEntity) => {
return title.title || `${title.vendor} ${title.model}`;
};
const profilesData: { [key: string]: Profile } = {};
const ProfileDetails: FunctionComponent<Props> = ({ selectedVersion, selectedProfile }) => {
@ -75,11 +72,9 @@ const ProfileDetails: FunctionComponent<Props> = ({ selectedVersion, selectedPro
useEffect(() => {
let mounted = true;
if (selectedVersion && selectedProfile) {
getProfileData().then((_profileData) => {
if (mounted && !isEqual(profile, _profileData)) setProfileData(_profileData);
});
}
getProfileData().then((_profileData) => {
if (mounted && !isEqual(profile, _profileData)) setProfileData(_profileData);
});
return () => {
mounted = false;
@ -143,14 +138,10 @@ const ProfileDetails: FunctionComponent<Props> = ({ selectedVersion, selectedPro
</Link>
);
})
.reduce((acc: ReactNode, curr: ReactNode) => [
.reduce((acc: ReactNode, curr: ReactNode, i: number) => [
acc,
// eslint-disable-next-line react/no-array-index-key
<Box
display="inline-block"
marginRight={2}
key={(acc?.toString() ?? '') + (curr?.toString() ?? '')}
/>,
<Box display="inline-block" marginRight={2} key={i} />,
curr,
])}
</TableCell>
@ -177,7 +168,7 @@ const ProfileDetails: FunctionComponent<Props> = ({ selectedVersion, selectedPro
.replace('{target}', profile.target)
.replace('{version}', profile.version_number)}/${i.name}`;
return (
<TableRow key={downloadURL}>
<TableRow key={downloadURL + i.type}>
<TableCell>
<Link href={downloadURL} target="_blank" data-testid="download_link">
<Button endIcon={<CloudDownload />} variant="contained" color="primary">